Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve column-didn't-generate error message #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwmanahan
Copy link

This code change will change the list of identical "Column type TIMESTAMP_LTZ is not supported for conversion from snowflake to looker. No dimension will be created." to start with the column names that aren't being converted.

This is useful to me and my peers because it tells us which columns need to be manually written and described in the LookML file. It continues to allow map_adapter_type_to_looker() to work as it currently does in case there is no column name (not sure this matters though!).

I've tested this by running the current prod dbt2looker command against a file in my company's codebase, then running the modified dbt2looker. More testing in the reviewer's environment wouldn't hurt.

This would be even better if model name were passed to the map_adapter_type_to_looker() function too to allow for the even clearer column name pattern of model_name.column_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant